Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple UI fixes #717

Merged
merged 5 commits into from
Jul 10, 2023
Merged

Multiple UI fixes #717

merged 5 commits into from
Jul 10, 2023

Conversation

kk7ds
Copy link
Owner

@kk7ds kk7ds commented Jul 10, 2023

  • Fetch user information when loading modules
  • Show memory fetch errors in row header tooltip
  • Allow editing/fixing failed-to-load memories
  • Fix disabling OK button in dialog while querying

This makes us look up the user information of a module that is selected
in the module loader. If that user does not have the developer role
on the project, warn the user before loading.
When we fail to load a memory we show the row label in red to indicate
this fact but do not allow an edit (or other edit operations that may
include these) because we don't have a cached memory object. This
patch makes us store an empty memory there so that an edit can
proceed, likely to resolve the issue by starting fresh.

Fixes #10705
@kk7ds kk7ds force-pushed the more-ui branch 2 times, most recently from a60a7e3 to 8a4163a Compare July 10, 2023 22:14
The CA RadioReference button was hijacking wx.ID_OK, preventing us
from finding and disabling the right button while a query was going
on. This fixes that by assigning it an ID of its own. Also disable
the OK button during CA login for clarity.

Fixes: #10704
@kk7ds kk7ds merged commit 5aaf773 into master Jul 10, 2023
@kk7ds kk7ds deleted the more-ui branch July 10, 2023 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant